Bug 195943

Summary:

User immediateScrollElementAtContentPointToOffset for scroll overlap tests

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Scrolling

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews104 for mac-highsierra-wk2	none
patch	none

Antti Koivisto

Reported 2019-03-19 06:58:01 PDT

Instead of simulated touch events.

Attachments
patch (4.98 KB, patch) 2019-03-19 07:04 PDT, Antti Koivisto	simon.fraser: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.64 MB, application/zip) 2019-03-19 08:17 PDT, EWS Watchlist	no flags	Details
patch (6.42 KB, patch) 2019-03-20 23:51 PDT, Antti Koivisto	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2019-03-19 07:04:23 PDT

Created attachment 365151 [details] patch

EWS Watchlist

Comment 2 2019-03-19 08:17:04 PDT

Comment on attachment 365151 [details] patch Attachment 365151 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11565744 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

EWS Watchlist

Comment 3 2019-03-19 08:17:05 PDT

Created attachment 365159 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6

Simon Fraser (smfr)

Comment 4 2019-03-20 09:16:59 PDT

Comment on attachment 365151 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=365151&action=review > LayoutTests/resources/basic-gestures.js:266 > +function immediateScrollElementAtContentPointToOffset(x, y, scrollX, scrollY) I don't know when we put things here vs ui-helper.js. Seems like they have a lot of overlap.

Antti Koivisto

Comment 5 2019-03-20 23:51:46 PDT

Created attachment 365504 [details] patch

WebKit Commit Bot

Comment 6 2019-03-21 01:25:23 PDT

Comment on attachment 365504 [details] patch Clearing flags on attachment: 365504 Committed r243281: <https://trac.webkit.org/changeset/243281>

WebKit Commit Bot

Comment 7 2019-03-21 01:25:25 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2019-03-21 01:26:21 PDT

<rdar://problem/49099567>

Note You need to log in before you can comment on or make changes to this bug.