Bug 195918

Summary: [GStreamer][EME] Backported mssdemux protection data crash fix
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: New BugsAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, pnormand, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/250
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-highsierra-wk2
none
Patch for landing none

Description Xabier Rodríguez Calvar 2019-03-18 16:18:45 PDT
[GStreamer][EME] Backported mssdemux protection data double free fix
Comment 1 Xabier Rodríguez Calvar 2019-03-18 16:19:49 PDT
Created attachment 365085 [details]
Patch

Backported https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/250
Comment 2 EWS Watchlist 2019-03-18 16:22:45 PDT
Attachment 365085 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: double free  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2019-03-18 18:58:07 PDT
Comment on attachment 365085 [details]
Patch

Attachment 365085 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11557057

New failing tests:
http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
Comment 4 EWS Watchlist 2019-03-18 18:58:09 PDT
Created attachment 365104 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 5 Xabier Rodríguez Calvar 2019-03-19 07:10:20 PDT
Created attachment 365153 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-03-19 07:48:55 PDT
Comment on attachment 365153 [details]
Patch for landing

Clearing flags on attachment: 365153

Committed r243139: <https://trac.webkit.org/changeset/243139>
Comment 7 WebKit Commit Bot 2019-03-19 07:48:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-19 07:49:24 PDT
<rdar://problem/49018681>