Bug 19591

Summary: [Qt] Dotted and solid borders are not drawn at the same position
Product: WebKit Reporter: Pierre-Luc Beaudoin <pierre-luc.beaudoin>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WORKSFORME    
Severity: Minor CC: jonathon, jturcotte
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Test case
none
Different testcase
none
Possible fix hausmann: review-

Pierre-Luc Beaudoin
Reported 2008-06-16 11:41:24 PDT
Dotted borders are not replaced by a solid border on the 4 sides (bottom and right are off by 1px) in test case (coming up).
Attachments
Test case (476 bytes, text/html)
2008-06-16 11:43 PDT, Pierre-Luc Beaudoin 		no flags
Details
Different testcase (563 bytes, text/html)
2008-06-26 08:45 PDT, Pierre-Luc Beaudoin 		no flags
Details
Possible fix (1.50 KB, patch)
2008-06-26 08:50 PDT, Pierre-Luc Beaudoin 		hausmann: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pierre-Luc Beaudoin
Comment 1 2008-06-16 11:43:24 PDT
Created attachment 21739 [details] Test case Actually, all 4 sides seems off by (-1px, -1px) if (0,0) if the upper left corner. To see this bug, hover the links with your mouse: the solid border is off.
Pierre-Luc Beaudoin
Comment 2 2008-06-26 08:45:30 PDT
Created attachment 21948 [details] Different testcase This one has more line sizes
Pierre-Luc Beaudoin
Comment 3 2008-06-26 08:50:04 PDT
Created attachment 21949 [details] Possible fix This fixes the issue by forcing anti-aliasing. My guess is that after calling adjustLineToPixelBoundaries(), the added 0.5 is floored when AA is off.
Simon Hausmann
Comment 4 2008-07-26 06:42:40 PDT
Comment on attachment 21949 [details] Possible fix Sorry, I don't see anti-aliasing making any difference here. But the real problem is that right now we can't afford to enable anti-aliasing for dotted lines, it's too slow.
Jocelyn Turcotte
Comment 5 2009-12-01 08:43:02 PST
I am not able to reproduce this problem in 4.5.3 or 4.6.0 This is an old bug and I will resolve it guessing that it was fixed. Please re-open if i'm wrong.
Note You need to log in before you can comment on or make changes to this bug.