Summary: | JSC test crash: stress/dont-strength-reduce-regexp-with-compile-error.js.default | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, rniwa, saam, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Michael Saboff
2019-03-18 13:26:32 PDT
Created attachment 365254 [details]
Patch
Comment on attachment 365254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365254&action=review r=me. Why not also do stack checks in opCompileAlternative(), opCompileBody(), and compile(). I think at minimum, it makes sense to do a check at the top level compile() function. This check will probably cover many functions that are 1 level deeper than compile(). Anything that can recurse below that will need additional checks. > Source/JavaScriptCore/ChangeLog:19 > + This change is covered by the previously added test that is failing. Would be nice to name the test here for reference. Comment on attachment 365254 [details] Patch Attachment 365254 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11573498 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html Created attachment 365287 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
(In reply to Mark Lam from comment #3) > Comment on attachment 365254 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=365254&action=review > > r=me. Why not also do stack checks in opCompileAlternative(), > opCompileBody(), and compile(). I think at minimum, it makes sense to do a > check at the top level compile() function. This check will probably cover > many functions that are 1 level deeper than compile(). Anything that can > recurse below that will need additional checks. Added a check in opCompileBody(). The recursion chain is opCompileParenthesesSubpattern() -> opCompileParenthesesSubpattern() -> opCompileAlternative() -> opCompileParenthesesSubpattern() ... Where opCompileParenthesesSubpattern could also be opCompileParentheticalAssertion. Given this, a stack check in opCompileParenthesesSubpattern and opCompileParentheticalAssertion is sufficient. > > Source/JavaScriptCore/ChangeLog:19 > > + This change is covered by the previously added test that is failing. > > Would be nice to name the test here for reference. Added. Committed r243237: <https://trac.webkit.org/changeset/243237> |