Summary: | Remove the inline capacity of Operands | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Robin Morisset
2019-03-18 11:18:14 PDT
Created attachment 365035 [details]
Patch
Comment on attachment 365035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365035&action=review r=me > Source/JavaScriptCore/ChangeLog:11 > + Still on JetStream 2, functions have an average of 18 BB, but those functions whose operands overflow have an average of 27 BB (so we are wasting 72kB on average when compiling them), and the largest function has 1241 BB (!), for a total of 3.3MB being wasted while it is compiled. I think FTL::OSRExitDescriptor also includes Operands, and it is kept alive during the code is live :) Comment on attachment 365035 [details] Patch Clearing flags on attachment: 365035 Committed r243088: <https://trac.webkit.org/changeset/243088> All reviewed patches have been landed. Closing bug. |