Bug 195897

Summary: [JSC] Add --destroy-vm shell option and dumpHeapStatisticsAtVMDestruction option
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, sbarati, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Description Yusuke Suzuki 2019-03-18 11:13:36 PDT
[JSC] Add --destroy-vm shell option and dumpHeapStatisticsAtVMDestruction option
Comment 1 Yusuke Suzuki 2019-03-18 11:19:13 PDT
Created attachment 365034 [details]
Patch
Comment 2 Keith Miller 2019-03-18 11:26:32 PDT
Comment on attachment 365034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365034&action=review

r=me with nits.

> Source/JavaScriptCore/ChangeLog:8
> +        It is useful if we have an option logging the status of all the existing MarkedBlock status and objects at VM destruction.

nit: existing MarkedBlock status and objects => existing MarkedBlocks and their objects

> Source/JavaScriptCore/ChangeLog:9
> +        I used this feature to find various wasting memory, and successfully removed many of wasting MarkedBlocks and  JS cells like r243081.

nit: find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells => find wasted memory, and successfully removed many wasted MarkedBlocks and JS cells
Comment 3 Yusuke Suzuki 2019-03-18 11:31:32 PDT
Comment on attachment 365034 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365034&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:8
>> +        It is useful if we have an option logging the status of all the existing MarkedBlock status and objects at VM destruction.
> 
> nit: existing MarkedBlock status and objects => existing MarkedBlocks and their objects

Fixed.

>> Source/JavaScriptCore/ChangeLog:9
>> +        I used this feature to find various wasting memory, and successfully removed many of wasting MarkedBlocks and  JS cells like r243081.
> 
> nit: find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells => find wasted memory, and successfully removed many wasted MarkedBlocks and JS cells

Fixed.
Comment 4 Yusuke Suzuki 2019-03-18 11:35:09 PDT
Committed r243086: <https://trac.webkit.org/changeset/243086>
Comment 5 Radar WebKit Bug Importer 2019-03-18 11:36:17 PDT
<rdar://problem/48986644>