Bug 195897

Summary: [JSC] Add --destroy-vm shell option and dumpHeapStatisticsAtVMDestruction option
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch keith_miller: review+

Yusuke Suzuki
Reported 2019-03-18 11:13:36 PDT
[JSC] Add --destroy-vm shell option and dumpHeapStatisticsAtVMDestruction option
Attachments
Patch (7.37 KB, patch)
2019-03-18 11:19 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-18 11:19:13 PDT
Created attachment 365034 [details] Patch
Keith Miller
Comment 2 2019-03-18 11:26:32 PDT
Comment on attachment 365034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365034&action=review r=me with nits. > Source/JavaScriptCore/ChangeLog:8 > + It is useful if we have an option logging the status of all the existing MarkedBlock status and objects at VM destruction. nit: existing MarkedBlock status and objects => existing MarkedBlocks and their objects > Source/JavaScriptCore/ChangeLog:9 > + I used this feature to find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells like r243081. nit: find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells => find wasted memory, and successfully removed many wasted MarkedBlocks and JS cells
Yusuke Suzuki
Comment 3 2019-03-18 11:31:32 PDT
Comment on attachment 365034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365034&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:8 >> + It is useful if we have an option logging the status of all the existing MarkedBlock status and objects at VM destruction. > > nit: existing MarkedBlock status and objects => existing MarkedBlocks and their objects Fixed. >> Source/JavaScriptCore/ChangeLog:9 >> + I used this feature to find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells like r243081. > > nit: find various wasting memory, and successfully removed many of wasting MarkedBlocks and JS cells => find wasted memory, and successfully removed many wasted MarkedBlocks and JS cells Fixed.
Yusuke Suzuki
Comment 4 2019-03-18 11:35:09 PDT
Committed r243086: <https://trac.webkit.org/changeset/243086>
Radar WebKit Bug Importer
Comment 5 2019-03-18 11:36:17 PDT
<rdar://problem/48986644>
Note You need to log in before you can comment on or make changes to this bug.