Bug 195885

Summary: [WPE] Tarballs generated with “make dist” cannot build documentation
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, darin, lforschler, mcatanzaro, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Adrian Perez 2019-03-18 07:46:38 PDT
Using the “dist” (or “distcheck”) targets results in a tarball
from which it is not possible to build the documentation using
gtk-doc. The error is:


  make: *** [Makefile:152: all] Error 2
  Traceback (most recent call last):
    File "/home/aperez/wpe/WebKit/Tools/Scripts/make-dist", line 345, in <module>
      Distcheck(arguments.source_dir, arguments.build_dir).check(output_filename, arguments.port)
    File "/home/aperez/wpe/WebKit/Tools/Scripts/make-dist", line 283, in check
      self.build(build_dir)
    File "/home/aperez/wpe/WebKit/Tools/Scripts/make-dist", line 257, in build
      subprocess.check_call(command, cwd=build_dir)
    File "/usr/lib64/python2.7/subprocess.py", line 190, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['make', '-j64']' returned non-zero exit status 2
  FAILED: Source/CMakeFiles/distcheck

Inspecting the generated tarball, file “Tools/glib/common.py” is
missing.
Comment 1 Adrian Perez 2019-03-18 07:53:17 PDT
Created attachment 365014 [details]
Patch
Comment 2 WebKit Commit Bot 2019-03-18 08:34:56 PDT
Comment on attachment 365014 [details]
Patch

Clearing flags on attachment: 365014

Committed r243066: <https://trac.webkit.org/changeset/243066>
Comment 3 WebKit Commit Bot 2019-03-18 08:34:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-18 08:35:44 PDT
<rdar://problem/48979604>