Summary: | [MSE][GStreamer] Don't construct segments on PlaybackPipeline::flush | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alicia Boya García <aboya> | ||||||||||||||
Component: | WebKitGTK | Assignee: | Alicia Boya García <aboya> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue, eric.carlson, jer.noble, mcatanzaro | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
See Also: | https://github.com/web-platform-tests/wpt/pull/15976 | ||||||||||||||||
Attachments: |
|
Description
Alicia Boya García
2019-03-17 16:30:53 PDT
Created attachment 364983 [details]
Patch
Comment on attachment 364983 [details]
Patch
Patch is right, but I think we should have a test for this.
And even better if we submit the test to the W3C test suite to backport it later here. Created attachment 365537 [details]
Patch
Created attachment 365538 [details]
Patch
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/15976 Comment on attachment 365538 [details]
Patch
The directory of imported test is only for imported tests. We shouldn't add a test there if it didn't land on the WPT repo yet. We need to move it to our LayoutTests/media/media-source/ while we wait for the other to land.
One this patch is landed, we create another bug to keep track of the WPT pull request.
Comment on attachment 365538 [details] Patch (In reply to Xabier Rodríguez Calvar from comment #7) > Comment on attachment 365538 [details] > Patch > > The directory of imported test is only for imported tests. We shouldn't add > a test there if it didn't land on the WPT repo yet. We need to move it to > our LayoutTests/media/media-source/ while we wait for the other to land. > > One this patch is landed, we create another bug to keep track of the WPT > pull request. Forget about this, everything is ok. Comment on attachment 365538 [details] Patch Rejecting attachment 365538 [details] from commit-queue. New failing tests: imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html Full output: https://webkit-queues.webkit.org/results/11600730 Created attachment 365564 [details]
Archive of layout-test-results from webkit-cq-02 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02 Port: mac-highsierra Platform: Mac OS X 10.13.6
(In reply to WebKit Commit Bot from comment #9) > Comment on attachment 365538 [details] > Patch > > Rejecting attachment 365538 [details] from commit-queue. > > New failing tests: > imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html > imported/w3c/web-platform-tests/media-source/mediasource-correct-frames- > after-reappend.html > Full output: https://webkit-queues.webkit.org/results/11600730 That looks bad! Jer, Eric, any insights? Drawing the <video> into the canvas does not seem to work in Safari (I tried doing so from the console to no effect). There seems to be also a problem getting the audio out of it for the AudioAnalyser. Potentially related: https://bugs.webkit.org/show_bug.cgi?id=153588 I'm marking the test as Skip in mac linking to that bug. Created attachment 365701 [details]
Patch for landing
Comment on attachment 365701 [details] Patch for landing Rejecting attachment 365701 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 365701, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=365701&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=195867&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 365701 from bug 195867. Fetching: https://bugs.webkit.org/attachment.cgi?id=365701 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 11 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/imported/w3c/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-after-reappend.html patching file LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-correct-frames-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html patching file LayoutTests/platform/mac/TestExpectations Hunk #1 FAILED at 1796. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11611555 Created attachment 365707 [details]
Patch for landing
Comment on attachment 365707 [details] Patch for landing Clearing flags on attachment: 365707 Committed r243372: <https://trac.webkit.org/changeset/243372> All reviewed patches have been landed. Closing bug. |