Bug 19586

Summary:

Show the file and line in the call frame next to the function name

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	aroben: review+

Timothy Hatcher

Reported 2008-06-16 09:53:05 PDT

We should show the file and line number next to each call frame in the Call Stack pane.

Attachments
Proposed patch (3.41 KB, patch) 2008-06-16 11:32 PDT, Timothy Hatcher	aroben: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2008-06-16 09:53:16 PDT

I have a fix for this.

Timothy Hatcher

Comment 2 2008-06-16 11:32:14 PDT

Created attachment 21733 [details] Proposed patch

Adam Roben (:aroben)

Comment 3 2008-06-17 13:45:29 PDT

Comment on attachment 21733 [details] Proposed patch + if (scriptOrResource instanceof WebInspector.Script) + subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL); + else if (scriptOrResource instanceof WebInspector.Resource) + subtitle = WebInspector.displayNameForURL(scriptOrResource.url); You could probably do this instead: subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL || scriptOrResource.url) Or we could make Scripts and Resources use the same property for their URL. r=me

Timothy Hatcher

Comment 4 2008-06-17 15:35:09 PDT

Landed in r34635.

Note You need to log in before you can comment on or make changes to this bug.