Bug 19586

Summary: Show the file and line in the call frame next to the function name
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch aroben: review+

Description Timothy Hatcher 2008-06-16 09:53:05 PDT
We should show the file and line number next to each call frame in the Call Stack pane.
Comment 1 Timothy Hatcher 2008-06-16 09:53:16 PDT
I have a fix for this.
Comment 2 Timothy Hatcher 2008-06-16 11:32:14 PDT
Created attachment 21733 [details]
Proposed patch
Comment 3 Adam Roben (:aroben) 2008-06-17 13:45:29 PDT
Comment on attachment 21733 [details]
Proposed patch

+            if (scriptOrResource instanceof WebInspector.Script)
+                subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL);
+            else if (scriptOrResource instanceof WebInspector.Resource)
+                subtitle = WebInspector.displayNameForURL(scriptOrResource.url);

You could probably do this instead:

subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL || scriptOrResource.url)

Or we could make Scripts and Resources use the same property for their URL.

r=me
Comment 4 Timothy Hatcher 2008-06-17 15:35:09 PDT
Landed in r34635.