Have smaller default quotas for third party frames

• Component: Service Workers
• Status: RESOLVED FIXED

[youenn fablet]

Have smaller default quotas for third party frames

[youenn fablet]

Created attachment 364903 [details]
Patch

[youenn fablet]

Created attachment 364916 [details]
Patch

[Geoffrey Garen]

Comment on attachment 364916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364916&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2342
> +        auto quota = origin.topOrigin == origin.clientOrigin ? storageQuotaManagers.defaultQuota : storageQuotaManagers.defaultQuota / 10;

Rather than dividing by 10, I think we want a thirdPartyQuota() helper function to match the defaultQuota() helper function. That way, they’ll be next to each other, and we’ll remember to update them together. (Dividing by 10 might not be right in the future, if we reduce the default quota.)

[youenn fablet]

Created attachment 365405 [details]
Patch for landing

[EWS Watchlist]

Attachment 365405 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkProcess.cpp:2032:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

Created attachment 365406 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 365406 [details]
Patch for landing

Clearing flags on attachment: 365406

Committed r243247: <https://trac.webkit.org/changeset/243247>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49081407>