Bug 195820

Summary: [iOS] Focus not preserved when switching between tabs
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196031
Bug Depends on:    
Bug Blocks: 190571, 196031    
Attachments:
Description Flags
Patch and tests
none
To land none

Description Daniel Bates 2019-03-15 14:33:39 PDT 
Steps to reproduce:

1. Open a tab with <https://www.wikipedia.org>.
2. Open a tab with <https://www.apple.com>, click the site search icon and type "iPad".
3. Switch to the Wikipedia tab using Command + 1 (or whatever number the Wikipedia tab is).
4. Switch back to the Apple.com tab using Command + 2 (or whatever number the Apple tab is).

The site search field will be defocused and needs to be explicitly focused to be able to type.
Comment 1 Daniel Bates 2019-03-15 14:33:52 PDT 
<rdar://problem/43614450>
Comment 2 Daniel Bates 2019-03-15 15:10:15 PDT 
Created attachment 364853 [details]
Patch and tests
Comment 3 Brent Fulgham 2019-03-18 21:19:21 PDT 
Comment on attachment 364853 [details]
Patch and tests

View in context: https://bugs.webkit.org/attachment.cgi?id=364853&action=review

r=me

> Source/WebKit/ChangeLog:9
> +        Fixes an usability annoyance when using a hardware keyboard; focus is not preserved when switching between tabs.

"a usability"
Comment 4 Daniel Bates 2019-03-19 11:24:34 PDT 
Created attachment 365188 [details]
To land
Comment 5 Daniel Bates 2019-03-19 11:25:32 PDT 
Committed r243153: <https://trac.webkit.org/changeset/243153>