Summary: | Remove incremental attribute and search event | ||
---|---|---|---|
Product: | WebKit | Reporter: | mike |
Component: | DOM | Assignee: | Anne van Kesteren <annevk> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | ahmad.saleem792, akeerthi, annevk, karlcow, rniwa, webkit-bug-importer, webkit, wenson_hsieh, zcorpan |
Priority: | P2 | Keywords: | InRadar, WPTImpact |
Version: | Safari 12 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=257686 https://bugs.chromium.org/p/chromium/issues/detail?id=690143 |
Description
mike
2019-03-15 13:43:55 PDT
Tests added in https://github.com/web-platform-tests/wpt/pull/19889 The test results suggest WebKit does support an incremental attribute. Only Firefox passes these tests: https://wpt.fyi/results/html/semantics/forms?label=master&label=experimental&aligned&view=subtest&q=historical-search-event.html https://wpt.fyi/results/html/semantics/forms/historical.html?label=master&label=experimental&aligned&view=subtest&q=html%2Fsemantics%2F _____ Do we have any strategy to remove these non-standards APIs? *** Bug 257687 has been marked as a duplicate of this bug. *** *** Bug 257686 has been marked as a duplicate of this bug. *** Pull request: https://github.com/WebKit/WebKit/pull/15788 I'm checking with Chromium if they're still interested in doing this: https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25. Aditya, are you still comfortable with what you said in https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262? (In reply to Anne van Kesteren from comment #7) > I'm checking with Chromium if they're still interested in doing this: > https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25. > > Aditya, are you still comfortable with what you said in > https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262? I'm slightly more concerned about removing the "search" event without a link check, since it could it completely break search functionality in apps that rely on it. Whereas, if we removed incremental without a link check, users could still use the enter key to initiate a search. I'm still comfortable with removing both from the web, but would lean towards keeping the "search" event with a link check, since we don't know the surface of apps we may affect. Committed 266068@main (99ff08340f12): <https://commits.webkit.org/266068@main> Reviewed commits have been landed. Closing PR #15788 and removing active labels. |