Bug 195817

Summary: Total not showing in JetStream2
Product: WebKit Reporter: Jon Davis <jond>
Component: JavaScriptCoreAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-feeder, ews-watchlist, rniwa, saam, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jon Davis
Reported 2019-03-15 13:34:33 PDT
There is a bug in setting the browser elements for changing the status and summary of the test.
Attachments
Patch (1.11 KB, patch)
2019-03-15 13:41 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (1.11 KB, patch)
2019-03-15 14:07 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2019-03-15 14:13 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2019-03-15 13:41:37 PDT
Created attachment 364832 [details] Patch
Ryosuke Niwa
Comment 2 2019-03-15 13:50:19 PDT
Comment on attachment 364832 [details] Patch Use let instead of var?
Jon Davis
Comment 3 2019-03-15 14:07:11 PDT
Created attachment 364839 [details] Patch
Jon Davis
Comment 4 2019-03-15 14:13:14 PDT
Created attachment 364841 [details] Patch
EWS
Comment 5 2019-03-15 14:17:22 PDT
Comment on attachment 364841 [details] Patch Rejecting attachment 364841 [details] from review queue. jond@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Commit Bot
Comment 6 2019-03-15 14:45:47 PDT
Comment on attachment 364841 [details] Patch Clearing flags on attachment: 364841 Committed r243013: <https://trac.webkit.org/changeset/243013>
WebKit Commit Bot
Comment 7 2019-03-15 14:45:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-15 15:10:32 PDT
<rdar://problem/48940241>
Note You need to log in before you can comment on or make changes to this bug.