Bug 195804 – Compute quota after network process restart based on default quota and space used

• Component: Service Workers
• Status: RESOLVED FIXED

[youenn fablet]

Compute quota after network process restart based on default quota and space used.

[youenn fablet]

Created attachment 364815 [details]
Patch

[youenn fablet]

Created attachment 364825 [details]
Patch

[Chris Dumez]

Comment on attachment 364825 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364825&action=review

> Source/WebCore/storage/StorageQuotaManager.cpp:71
> +        initializeQuotaAccordingSpaceUsage();

Not a great name. AccordingTo at least to be correct although I wish the name was shorter.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:-60
> -    quotaManager.addUser(*this);

Why this change? I thought it looked in the constructor.

[youenn fablet]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 364825 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364825&action=review
> 
> > Source/WebCore/storage/StorageQuotaManager.cpp:71
> > +        initializeQuotaAccordingSpaceUsage();
> 
> Not a great name. AccordingTo at least to be correct although I wish the
> name was shorter.

OK.

> > Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp:-60
> > -    quotaManager.addUser(*this);
> 
> Why this change? I thought it looked in the constructor.

When added as a quota user, whenInitialized will be called.
This will trigger a call to initialize which will try to ref 'this'.
This must be done once 'this' is adopted.

I think a follow-up patch will try to delay initialization to the first call of requestSpace with a task size greater than zero.

[youenn fablet]

Created attachment 365353 [details]
Patch

[youenn fablet]

Created attachment 365451 [details]
Patch

[Chris Dumez]

Comment on attachment 365451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365451&action=review

> Source/WebCore/storage/StorageQuotaManager.cpp:47
> +void StorageQuotaManager::setQuotaBasedOnSpaceUsage()

maybe updateQuotaBasedOnSpaceUsage() since it is not a one time thing. Also, it makes no parameter.

[youenn fablet]

Created attachment 365477 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

(In reply to Chris Dumez from comment #7)
> Comment on attachment 365451 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365451&action=review
> 
> > Source/WebCore/storage/StorageQuotaManager.cpp:47
> > +void StorageQuotaManager::setQuotaBasedOnSpaceUsage()
> 
> maybe updateQuotaBasedOnSpaceUsage() since it is not a one time thing. Also,
> it makes no parameter.

OK

[WebKit Commit Bot]

Comment on attachment 365477 [details]
Patch for landing

Clearing flags on attachment: 365477

Committed r243276: <https://trac.webkit.org/changeset/243276>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49093838>