Bug 195798

Summary: [WTF] Remove redundant std::move in StringConcatenate
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Remove redundant WTFMove calls none

Description Xan Lopez 2019-03-15 03:29:01 PDT
GCC (since 9.x when -Wredundant-move is enabled by default) warns of two redundant move operations in StringConcatenate. AFAICT the issue is that C++ will already do an implicit move when a local value is returned and copy (or move) elision is not applicable, as in here.
Comment 1 Xan Lopez 2019-03-15 03:34:23 PDT
Created attachment 364786 [details]
Remove redundant WTFMove calls
Comment 2 WebKit Commit Bot 2019-03-18 16:51:48 PDT
Comment on attachment 364786 [details]
Remove redundant WTFMove calls

Clearing flags on attachment: 364786

Committed r243115: <https://trac.webkit.org/changeset/243115>
Comment 3 WebKit Commit Bot 2019-03-18 16:51:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-18 16:52:16 PDT