Bug 195798

Summary: [WTF] Remove redundant std::move in StringConcatenate
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, webkit-bug-importer, xan.lopez
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove redundant WTFMove calls none

Xan Lopez
Reported 2019-03-15 03:29:01 PDT
GCC (since 9.x when -Wredundant-move is enabled by default) warns of two redundant move operations in StringConcatenate. AFAICT the issue is that C++ will already do an implicit move when a local value is returned and copy (or move) elision is not applicable, as in here.
Attachments
Remove redundant WTFMove calls (2.25 KB, patch)
2019-03-15 03:34 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2019-03-15 03:34:23 PDT
Created attachment 364786 [details] Remove redundant WTFMove calls
WebKit Commit Bot
Comment 2 2019-03-18 16:51:48 PDT
Comment on attachment 364786 [details] Remove redundant WTFMove calls Clearing flags on attachment: 364786 Committed r243115: <https://trac.webkit.org/changeset/243115>
WebKit Commit Bot
Comment 3 2019-03-18 16:51:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-03-18 16:52:16 PDT
<rdar://problem/49000128>
Note You need to log in before you can comment on or make changes to this bug.