| Summary: | Remove retain cycle from JSScript and also don't keep the cache file descriptor open so many JSScripts can be cached in a loop | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, ews-watchlist, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2019-03-14 16:59:43 PDT
Created attachment 364726 [details]
patch
Attachment 364726 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:2205: One line control clauses should not use braces. [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:2237: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=364726&action=review r=me > Source/JavaScriptCore/API/JSScript.mm:290 > + error = "No cache was path provided during construction of this JSScript."_s; I know you didn't change this error message, but shouldn't it read "No cache *path was* provided during construction of this JSScript."? Comment on attachment 364726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=364726&action=review >> Source/JavaScriptCore/API/JSScript.mm:290 >> + error = "No cache was path provided during construction of this JSScript."_s; > > I know you didn't change this error message, but shouldn't it read "No cache *path was* provided during construction of this JSScript."? Yeah will fix. Created attachment 364743 [details]
patch for landing
|