Summary: | CacheStorageConnection callbacks should be completed on network connection close | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, cdumez, commit-queue, ryanhaddad, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 198134 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
youenn fablet
2019-03-14 13:24:39 PDT
Another approach is to rely on AsyncReply Created attachment 370455 [details]
Patch
Created attachment 370480 [details]
Patch
Comment on attachment 370480 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370480&action=review rs=me when this builds. > Source/WebKit/ChangeLog:48 > + * WebProcess/Cache/WebCacheStorageConnection.h: It looks like you need to remove the declaration of WebCacheStorageConnection::didReceiveMessage and see what breaks and fix that. Created attachment 370509 [details]
Patch for landing
Comment on attachment 370509 [details] Patch for landing Clearing flags on attachment: 370509 Committed r245715: <https://trac.webkit.org/changeset/245715> All reviewed patches have been landed. Closing bug. This change broke a webkitpy test: [5/1902] webkit.messages_unittest.ReceiverImplementationTest.test_receiver_implementations failed: Traceback (most recent call last): File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 393, in test_receiver_implementations _expected_superclass_receiver_implementation_file_name) File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 373, in assertImplementationEqual self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name) File "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 360, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: ' completionHandler(IPC::AsyncReplyError<uint64_t>::create());' != ' return;' https://build.webkit.org/builders/Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/4289/steps/webkitpy-test/logs/stdio (In reply to Ryan Haddad from comment #9) > This change broke a webkitpy test: > > [5/1902] > webkit.messages_unittest.ReceiverImplementationTest. > test_receiver_implementations failed: > Traceback (most recent call last): > File > "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/ > webkit/messages_unittest.py", line 393, in test_receiver_implementations > _expected_superclass_receiver_implementation_file_name) > File > "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/ > webkit/messages_unittest.py", line 373, in assertImplementationEqual > self.assertGeneratedFileContentsEqual(actual_file_contents, > expected_file_name) > File > "/Volumes/Data/slave/mojave-release-tests-wk2/build/Source/WebKit/Scripts/ > webkit/messages_unittest.py", line 360, in assertGeneratedFileContentsEqual > self.assertEquals(actual_line, expected_line_list[index]) > AssertionError: ' > completionHandler(IPC::AsyncReplyError<uint64_t>::create());' != ' > return;' > > https://build.webkit.org/builders/ > Apple%20Mojave%20Release%20WK2%20%28Tests%29/builds/4289/steps/webkitpy-test/ > logs/stdio Filed bug 198214. |