Bug 195753

Summary:

[ews-app] Gracefully handle the case when state_string is None

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dewei_zhu, jbedard, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2019-03-14 11:56:15 PDT

ews-app should gracefully handle the case when 'state_string' sent by buildbot is None. Currently it results in a database exception: IntegrityError: NOT NULL constraint failed: ews_step.state_string

Comment 1 Aakash Jain 2019-03-14 11:59:03 PDT

Created attachment 364673 [details]
Patch

Comment 2 Jonathan Bedard 2019-03-14 12:02:36 PDT

Assuming we're ok displaying an empty state string (and I think we are), this looks good to me. Note that this is a response to comments I had in <https://bugs.webkit.org/show_bug.cgi?id=195744>.

Comment 3 WebKit Commit Bot 2019-03-14 14:44:41 PDT

Comment on attachment 364673 [details]
Patch

Clearing flags on attachment: 364673

Committed r242966: <https://trac.webkit.org/changeset/242966>

Comment 4 WebKit Commit Bot 2019-03-14 14:44:42 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2019-03-14 14:45:16 PDT

<rdar://problem/48902526>