| Summary: | REGRESSION(r242841): Fix conservative DFG OSR entry validation to accept values which will be stored in AnyInt / Double flush formats | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yusuke Suzuki
2019-03-14 11:35:00 PDT
Created attachment 364670 [details]
Patch
Created attachment 364680 [details]
Patch
Comment on attachment 364680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364680&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] DFG OSR entry tends to reject Double and AnyInt values nit: this makes it seem like this is a longstanding issue. It's not. It regressed only recently. It'd be good for this title to acknowledge that this just regressed. > Source/JavaScriptCore/ChangeLog:8 > + We fix the bug skipping AbstractValue validations when the flush format is Double or AnyInt. But it you should say what revision. "fix" => "fixed" Comment on attachment 364680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364680&action=review Thanks! >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] DFG OSR entry tends to reject Double and AnyInt values > > nit: this makes it seem like this is a longstanding issue. It's not. It regressed only recently. It'd be good for this title to acknowledge that this just regressed. Sounds nice! I changed the title to "REGRESSION(r242841): Fix conservative DFG OSR entry validation to accept values which will be stored in AnyInt / Double flush formats" >> Source/JavaScriptCore/ChangeLog:8 >> + We fix the bug skipping AbstractValue validations when the flush format is Double or AnyInt. But it > > you should say what revision. > "fix" => "fixed" Fixed. Committed r242990: <https://trac.webkit.org/changeset/242990> |