Bug 19575

Summary: layout test svg/batik/text/textDecoration.svg hangs
Product: WebKit Reporter: Jean-Charles Verdié <jcverdie>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, webkit
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 19569    
Attachments:
Description Flags
Patch darin: review+

Jean-Charles Verdié
Reported 2008-06-16 04:14:28 PDT
stderr: ASSERTION FAILED: !m_pattern (/Users/jcverdie/owb/webkit/WebCore/svg/graphics/cg/SVGPaintServerPatternCg.cpp:83 virtual bool WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, const WebCore::RenderObject*, WebCore::SVGPaintTargetType, bool) const) HangReport: Call graph: 954 Thread_2603 954 start 954 main 954 dumpRenderTree(int, char const**) 954 runTestingServerLoop() 954 runTest(char const*) 954 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 954 CFRunLoopRunInMode 954 CFRunLoopRunSpecific 954 muxerSourcePerform 954 _CFURLConnectionSendCallbacks 954 sendDidFinishLoadingCallback 954 _NSURLConnectionDidFinishLoading 954 -[NSURLConnection(NSURLConnectionReallyInternal) sendDidFinishLoading] 954 -[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:] 954 WebCore::ResourceLoader::didFinishLoading(WebCore::ResourceHandle*) 954 WebCore::SubresourceLoader::didFinishLoading() 954 WebCore::DocumentLoader::removeSubresourceLoader(WebCore::ResourceLoader*) 954 WebCore::FrameLoader::checkLoadComplete() 954 WebCore::FrameLoader::recursiveCheckLoadComplete() 954 WebCore::FrameLoader::checkLoadCompleteForThisFrame() 954 WebFrameLoaderClient::dispatchDidFinishLoad() 954 CallFrameLoadDelegate(objc_object* (*)(objc_object*, objc_selector*, ...), WebView*, objc_selector*, objc_object*) 954 CallDelegate(objc_object* (*)(objc_object*, objc_selector*, ...), WebView*, objc_object*, objc_selector*, objc_object*) 954 -[FrameLoadDelegate webView:didFinishLoadForFrame:] 954 -[NSView displayIfNeeded] 954 -[NSView _displayRectIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:] 954 -[NSNextStepFrame _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 954 -[NSView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[WebHTMLView(WebPrivate) _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] 954 -[NSView _drawRect:clip:] 954 -[WebHTMLView drawRect:] 954 -[WebHTMLView drawSingleRect:] 954 -[WebFrame(WebInternal) _drawRect:] 954 WebCore::Frame::paint(WebCore::GraphicsContext*, WebCore::IntRect const&) 954 WebCore::RenderLayer::paint(WebCore::GraphicsContext*, WebCore::IntRect const&, WebCore::PaintRestriction, WebCore::RenderObject*) 954 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, WebCore::PaintRestriction, WebCore::RenderObject*, bool) 954 WebCore::RenderLayer::paintLayer(WebCore::RenderLayer*, WebCore::GraphicsContext*, WebCore::IntRect const&, bool, WebCore::PaintRestriction, WebCore::RenderObject*, bool) 954 WebCore::RenderSVGRoot::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderBox::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderSVGText::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderBlock::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderBlock::paintObject(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderBlock::paintContents(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::RenderFlow::paintLines(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::SVGRootInlineBox::paint(WebCore::RenderObject::PaintInfo&, int, int) 954 WebCore::SVGRootInlineBox::walkTextChunks(WebCore::SVGTextChunkWalkerBase*, WebCore::SVGInlineTextBox const*) 954 WebCore::SVGTextChunkWalker<WebCore::SVGRootInlineBoxPaintWalker>::operator()(WebCore::SVGInlineTextBox*, int, WebCore::AffineTransform const&, WebCore::SVGChar* const&, WebCore::SVGChar* const&) 954 WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback(WebCore::SVGInlineTextBox*, int, WebCore::AffineTransform const&, WebCore::SVGChar* const&, WebCore::SVGChar* const&) 954 WebCore::SVGInlineTextBox::paintDecoration(WebCore::ETextDecoration, WebCore::GraphicsContext*, int, int, int, WebCore::SVGChar const&, WebCore::SVGTextDecorationInfo const&) 954 WebCore::SVGPaintServer::draw(WebCore::GraphicsContext*&, WebCore::RenderObject const*, WebCore::SVGPaintTargetType) const 954 WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, WebCore::RenderObject const*, WebCore::SVGPaintTargetType, bool) const 954 WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, WebCore::RenderObject const*, WebCore::SVGPaintTargetType, bool) const 954 Thread_2703 954 thread_start 954 _pthread_start 954 CFURLCacheWorkerThread(void*) 954 CFRunLoopRunInMode 954 CFRunLoopRunSpecific 954 mach_msg 954 mach_msg_trap 954 mach_msg_trap 954 Thread_2803 954 thread_start 954 _pthread_start 954 __NSThread__main__ 954 -[NSThread main] 954 +[NSURLConnection(NSURLConnectionReallyInternal) _resourceLoadLoop:] 954 CFRunLoopRunInMode 954 CFRunLoopRunSpecific 954 mach_msg 954 mach_msg_trap 954 mach_msg_trap Total number in stack (recursive counted multiple, when >=5): 7 -[NSView _recursiveDisplayAllDirtyWithLockFocus:visRect:] Sort by top of stack, same collapsed (when >= 5): mach_msg_trap 1908 WebCore::SVGPaintServerPattern::setup(WebCore::GraphicsContext*&, WebCore::RenderObject const*, WebCore::SVGPaintTargetType, bool) const 954
Attachments
Patch (68.78 KB, patch)
2010-06-18 12:14 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Blaut
Comment 1 2008-12-28 13:37:12 PST
This test doesn't crash in WebKit r39474. So I think it's time to re-enable it.
Rob Buis
Comment 2 2010-06-18 12:14:20 PDT
Created attachment 59142 [details] Patch
Darin Adler
Comment 3 2010-06-18 13:26:30 PDT
Comment on attachment 59142 [details] Patch rs=me
Rob Buis
Comment 4 2010-06-19 02:43:12 PDT
Landed in r61465.
Note You need to log in before you can comment on or make changes to this bug.