| Summary: | [WPE] Confusing messages in stderr when surfaceless context is not supported | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
| Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, bugs-noreply, magomez, zan | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 364654 [details]
Patch
(In reply to Carlos Garcia Campos from comment #0) > Cannot create EGL surfaceless context: missing > EGL_KHR_surfaceless_{context,opengl} extension. > Cannot create EGL WPE context: EGL_SUCCESS > > It seems like there's anything wrong, while there isn't. > [...] I have to admit the first time I noticed these messages they were indeed confusing; it will be good to just go ahead and remove them, IMO. Comment on attachment 364654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364654&action=review > Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp:77 > + if (context == EGL_NO_CONTEXT) { > + WTFLogAlways("Cannot create EGL WPE context: %s\n", lastErrorString()); > + return nullptr; > + } This needs to destroy the offscreen target before returning early. Comment on attachment 364654 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364654&action=review >> Source/WebCore/platform/graphics/egl/GLContextEGLLibWPE.cpp:77 >> + } > > This needs to destroy the offscreen target before returning early. Right! I fixed the context leak to introduce a target leak :-P Created attachment 365341 [details]
Patch
Committed r243284: <https://trac.webkit.org/changeset/243284> |
Cannot create EGL surfaceless context: missing EGL_KHR_surfaceless_{context,opengl} extension. Cannot create EGL WPE context: EGL_SUCCESS It seems like there's anything wrong, while there isn't. It's also confusing an error message where the error is EGL_SUCCESS. I think we should not show those messages at all, not suporting surfaceless contexts is not an error and it's correctly handled. Failing to get a native window handle from render backend offscreen egl target is not an error either, since most of the backend don't implement the interface (they actually have an empty implementation).