Bug 195733

Summary:

[Async overflow scrolling] Update positioned node layers when overflows are scrolled

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, fred.wang, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

195780

Bug Blocks:

Attachments:

Description	Flags
Code ready, needs tests.	none
Code ready, needs tests	none
Code ready, needs tests	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Archive of layout-test-results from ews200 for win-future	none
Patch	none

Simon Fraser (smfr)

Reported 2019-03-13 20:36:47 PDT

[Coordinated Scrolling] Update positioned node layers when overflows are scrolled

Attachments
Code ready, needs tests. (24.69 KB, patch) 2019-03-13 20:44 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Code ready, needs tests (25.49 KB, patch) 2019-03-13 20:51 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Code ready, needs tests (25.50 KB, patch) 2019-03-13 21:04 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.89 MB, application/zip) 2019-03-13 23:00 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews200 for win-future (12.88 MB, application/zip) 2019-03-14 00:47 PDT, EWS Watchlist	no flags	Details
Patch (35.50 KB, patch) 2019-03-14 17:54 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2019-03-13 20:44:55 PDT Comment hidden (obsolete)

Created attachment 364621 [details] Code ready, needs tests.

Simon Fraser (smfr)

Comment 2 2019-03-13 20:44:57 PDT

<rdar://problem/11642295>

Simon Fraser (smfr)

Comment 3 2019-03-13 20:51:49 PDT Comment hidden (obsolete)

Created attachment 364624 [details] Code ready, needs tests

Simon Fraser (smfr)

Comment 4 2019-03-13 21:04:29 PDT Comment hidden (obsolete)

Created attachment 364625 [details] Code ready, needs tests

EWS Watchlist

Comment 5 2019-03-13 23:00:04 PDT Comment hidden (obsolete)

Comment on attachment 364625 [details] Code ready, needs tests Attachment 364625 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11500674 New failing tests: scrollingcoordinator/ios/ui-scrolling-tree.html

EWS Watchlist

Comment 6 2019-03-13 23:00:06 PDT Comment hidden (obsolete)

Created attachment 364635 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

EWS Watchlist

Comment 7 2019-03-14 00:46:55 PDT Comment hidden (obsolete)

Comment on attachment 364625 [details] Code ready, needs tests Attachment 364625 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11501551 New failing tests: storage/indexeddb/modern/gc-closes-database-private.html

EWS Watchlist

Comment 8 2019-03-14 00:47:06 PDT Comment hidden (obsolete)

Created attachment 364640 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Simon Fraser (smfr)

Comment 9 2019-03-14 17:54:21 PDT

Created attachment 364737 [details] Patch

Antti Koivisto

Comment 10 2019-03-15 08:50:37 PDT

Comment on attachment 364737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364737&action=review r=me > Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.mm:80 > + // Note that we ignore cumulativeDelta because it will contain the delta for ancestor scrollers, > + // but not non-ancestor ones, so it's simpler to just recompute from the scrollers we know about here. Would be nice to have a single unified way to do this everywhere.

WebKit Commit Bot

Comment 11 2019-03-15 09:26:15 PDT

Comment on attachment 364737 [details] Patch Clearing flags on attachment: 364737 Committed r242997: <https://trac.webkit.org/changeset/242997>

WebKit Commit Bot

Comment 12 2019-03-15 09:26:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.