| Summary: | [Async overflow scrolling] Update positioned node layers when overflows are scrolled | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fred.wang, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 195780 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Simon Fraser (smfr)
2019-03-13 20:36:47 PDT
Created attachment 364621 [details]
Code ready, needs tests.
Created attachment 364624 [details]
Code ready, needs tests
Created attachment 364625 [details]
Code ready, needs tests
Comment on attachment 364625 [details] Code ready, needs tests Attachment 364625 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11500674 New failing tests: scrollingcoordinator/ios/ui-scrolling-tree.html Created attachment 364635 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 364625 [details] Code ready, needs tests Attachment 364625 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/11501551 New failing tests: storage/indexeddb/modern/gc-closes-database-private.html Created attachment 364640 [details]
Archive of layout-test-results from ews200 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 364737 [details]
Patch
Comment on attachment 364737 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364737&action=review r=me > Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.mm:80 > + // Note that we ignore cumulativeDelta because it will contain the delta for ancestor scrollers, > + // but not non-ancestor ones, so it's simpler to just recompute from the scrollers we know about here. Would be nice to have a single unified way to do this everywhere. Comment on attachment 364737 [details] Patch Clearing flags on attachment: 364737 Committed r242997: <https://trac.webkit.org/changeset/242997> All reviewed patches have been landed. Closing bug. |