|Summary:||Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists|
|Product:||WebKit||Reporter:||Devin Rousso <drousso>|
|Component:||Web Inspector||Assignee:||Devin Rousso <drousso>|
|Severity:||Normal||CC:||commit-queue, drousso, inspector-bugzilla-changes, mattbaker, webkit-bug-importer|
|Version:||WebKit Nightly Build|
|Bug Depends on:|
|Bug Blocks:||173807, 175485|
Description Devin Rousso 2019-03-13 20:19:37 PDT
# STEPS TO REPRODUCE: 1. inspect any page with a <canvas> 2. take a multi-frame recording (or a single frame that is very very long) 3. stop the recording 4. wait for the recording content view to appear and the recording actions to start processing => no action is initially selected, which means that there is no preview in the main content area
Comment 4 Matt Baker 2019-03-14 11:43:11 PDT
Comment on attachment 364620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364620&action=review r=me > Source/WebInspectorUI/ChangeLog:11 > + Rather than wait till the entire recording is ready, set the selected action as soon as the s/till/until > Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js:581 > + this.action = action; So `action` here is equivalent to this._recording.actions, if the recording were ready?
Comment 5 Devin Rousso 2019-03-14 13:17:58 PDT
Comment on attachment 364620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364620&action=review >> Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js:581 >> + this.action = action; > > So `action` here is equivalent to this._recording.actions, if the recording were ready? Yes, but not if the recording is ready. This event listener is only fired when processing actions, so this check is basically saying "when we process an action, if we haven't set a selected action yet, use this action". Although it's effectively impossible (unless some funky stuff happens, or this is changed in the future) for this if to be hit by anything other than the first action, I'll change it to `this._recording.actions` just in case.
Comment 7 WebKit Commit Bot 2019-03-14 13:48:44 PDT
Comment on attachment 364679 [details] Patch Clearing flags on attachment: 364679 Committed r242962: <https://trac.webkit.org/changeset/242962>
Comment 8 WebKit Commit Bot 2019-03-14 13:48:45 PDT
All reviewed patches have been landed. Closing bug.