| Summary: | Web Inspector: DOM: include window as part of any event listener chain | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, msaboff, rniwa, saam, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | 195713 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Devin Rousso
2019-03-13 19:32:51 PDT
This should also include setting breakpoints on window event listeners, as well as showing `window` when paused on a window event listener. Created attachment 364961 [details]
Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features. Comment on attachment 364961 [details] Patch Rejecting attachment 364961 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 364961, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=364961&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=195730&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 364961 from bug 195730. Fetching: https://bugs.webkit.org/attachment.cgi?id=364961 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 18 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebInspectorUI/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/inspector/protocol/DOM.json patching file Source/WebCore/inspector/agents/InspectorDOMAgent.cpp Hunk #6 succeeded at 1654 with fuzz 1. patching file Source/WebCore/inspector/agents/InspectorDOMAgent.h patching file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js Hunk #1 FAILED at 510. Hunk #2 succeeded at 1023 (offset 3 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js.rej patching file Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.css patching file Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js patching file Source/WebInspectorUI/UserInterface/Views/EventListenerSectionGroup.js patching file Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.css Hunk #1 succeeded at 106 (offset 8 lines). patching file Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js Hunk #1 succeeded at 132 (offset 10 lines). Hunk #2 succeeded at 896 (offset 79 lines). Hunk #3 succeeded at 1265 (offset 79 lines). Hunk #4 succeeded at 1403 (offset 102 lines). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/inspector/dom/event-listener-add-remove.html patching file LayoutTests/inspector/dom/getEventListenersForNode-expected.txt patching file LayoutTests/inspector/dom/getEventListenersForNode.html patching file LayoutTests/inspector/dom/setEventListenerDisabled.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11580938 Created attachment 365366 [details]
Patch
Comment on attachment 365366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365366&action=review > Source/JavaScriptCore/inspector/protocol/DOM.json:91 > - { "name": "nodeId", "$ref": "NodeId", "description": "Target <code>DOMNode</code> id." }, > + { "name": "nodeId", "$ref": "NodeId", "optional": true, "description": "The target <code>DOMNode</code> id if the event listener is for a node." }, > + { "name": "onWindow", "type": "boolean", "optional": true, "description": "True if the event listener was added to the window." }, Should let ITML folks know about these DOM changes as well. Comment on attachment 365366 [details] Patch Attachment 365366 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11584231 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html Created attachment 365399 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365366 [details] Patch Clearing flags on attachment: 365366 Committed r243244: <https://trac.webkit.org/changeset/243244> All reviewed patches have been landed. Closing bug. |