Bug 195693 – Web Inspector: HAR Extension for Resource Priority

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

HAR Extension for Resource Priority

• We include _fetchType we can include _priority

[Joseph Pecoraro]

Created attachment 364829 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 364862 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 364862 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364862&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:332
> +        case WI.Resource.NetworkPriority.Low:
> +            return "low";
> +        case WI.Resource.NetworkPriority.Medium:
> +            return "medium";
> +        case WI.Resource.NetworkPriority.High:
> +            return "high";

Could we use the `NetworkAgent.MetricsPriority` values instead, or are you worried about backward/forward compatibility?

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:335
> +        console.assert(false);

`console.assert()` works instead of this :P

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:380
> -            console.warn("Unknown HAR Protocol _fetchType", fetchType);
> +            console.warn("Unknown HAR _fetchType value", fetchType);

Oops :P

> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:392
> +        case "low":
> +            return WI.Resource.NetworkPriority.Low;
> +        case "medium":
> +            return WI.Resource.NetworkPriority.Medium;
> +        case "high":
> +            return WI.Resource.NetworkPriority.High;

Ditto (>327).

[Joseph Pecoraro]

Comment on attachment 364862 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364862&action=review

>> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:332
>> +            return "high";
> 
> Could we use the `NetworkAgent.MetricsPriority` values instead, or are you worried about backward/forward compatibility?

Yeah I don't want changing the protocol to break HAR import/export expectations.

>> Source/WebInspectorUI/UserInterface/Controllers/HARBuilder.js:392
>> +            return WI.Resource.NetworkPriority.High;
> 
> Ditto (>327).

These we are converting back from the HAR to WI.Resource so we'd want what we serialized into the HAR.

[Joseph Pecoraro]

https://trac.webkit.org/r243031

[Joseph Pecoraro]

bump to try and get radar importer to import

[Radar WebKit Bug Importer]

<rdar://problem/48986580>