Bug 195687

Summary: Web Inspector: Protocol Logging: log messages with backtrace if inspector^2 is open
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2019-03-13 11:30:10 PDT
This would make debugging with inspector2 open SO much nicer, as I could see the trace of each command.
Attachments
Patch (1.91 KB, patch)
2019-03-13 11:33 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-03-13 11:33:05 PDT
Created attachment 364552 [details] Patch
Joseph Pecoraro
Comment 2 2019-03-13 11:35:28 PDT
Comment on attachment 364552 [details] Patch rs=me. Should we have a trace that doesn't auto-expand?
Devin Rousso
Comment 3 2019-03-13 11:59:48 PDT
Comment on attachment 364552 [details] Patch (In reply to Joseph Pecoraro from comment #2) > Should we have a trace that doesn't auto-expand? Eh, if anything I'd make that a global setting. Creating a specialized path for a non-expanding `console.trace` seems like a detail that developers shouldn't be concerned with (e.g. thats a setting/"preference" of the developer and/or the tools). <https://webkit.org/b/195690>
WebKit Commit Bot
Comment 4 2019-03-13 12:28:32 PDT
Comment on attachment 364552 [details] Patch Clearing flags on attachment: 364552 Committed r242898: <https://trac.webkit.org/changeset/242898>
WebKit Commit Bot
Comment 5 2019-03-13 12:28:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-13 12:59:11 PDT
<rdar://problem/48859330>
Note You need to log in before you can comment on or make changes to this bug.