| Summary: | [GStreamer][WebRTC] Do not sync encoder on the clock | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||||
| Component: | New Bugs | Assignee: | Thibault Saunier <tsaunier> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, pnormand, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Thibault Saunier
2019-03-13 07:14:54 PDT
Created attachment 364527 [details]
Patch
Comment on attachment 364527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364527&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:145 > + g_object_set(sink, "sync", FALSE, NULL); Please at least remain consistent with the code below and use nullptr :) Created attachment 364535 [details]
Patch for landing
Comment on attachment 364535 [details] Patch for landing Rejecting attachment 364535 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364535, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11489929 Created attachment 364536 [details]
Patch for landing
Comment on attachment 364536 [details] Patch for landing Clearing flags on attachment: 364536 Committed r242883: <https://trac.webkit.org/changeset/242883> All reviewed patches have been landed. Closing bug. |