Bug 195673

Summary: [GStreamer][WebRTC] Do not sync encoder on the clock
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Thibault Saunier
Reported 2019-03-13 07:14:54 PDT
[GStreamer][WebRTC] Do not sync encoder on the clock
Attachments
Patch (1.75 KB, patch)
2019-03-13 07:15 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.75 KB, patch)
2019-03-13 08:06 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.76 KB, patch)
2019-03-13 08:30 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2019-03-13 07:15:18 PDT
Created attachment 364527 [details] Patch
Philippe Normand
Comment 2 2019-03-13 07:41:48 PDT
Comment on attachment 364527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364527&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:145 > + g_object_set(sink, "sync", FALSE, NULL); Please at least remain consistent with the code below and use nullptr :)
Thibault Saunier
Comment 3 2019-03-13 08:06:21 PDT
Created attachment 364535 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-03-13 08:08:10 PDT
Comment on attachment 364535 [details] Patch for landing Rejecting attachment 364535 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364535, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11489929
Thibault Saunier
Comment 5 2019-03-13 08:30:11 PDT
Created attachment 364536 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-03-13 09:08:20 PDT
Comment on attachment 364536 [details] Patch for landing Clearing flags on attachment: 364536 Committed r242883: <https://trac.webkit.org/changeset/242883>
WebKit Commit Bot
Comment 7 2019-03-13 09:08:22 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-13 09:31:06 PDT
<rdar://problem/48849834>
Note You need to log in before you can comment on or make changes to this bug.