Summary: | [bmalloc] Use MADV_FREE on FreeBSD | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, don.olmstead, ggaren, webkit-bug-importer, yoshiaki.jitsukawa | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Yoshiaki Jitsukawa
2019-03-13 00:07:52 PDT
Created attachment 364517 [details]
Patch
Comment on attachment 364517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364517&action=review > Source/bmalloc/bmalloc/VMAllocate.h:204 > +#else Can this be #elif? > Source/bmalloc/bmalloc/VMAllocate.h:205 > +#if !BOS(LINUX) && defined(MADV_FREE) We do have a platform macro for FreeBSD. Can you use that? (In reply to Geoffrey Garen from comment #2) > Comment on attachment 364517 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364517&action=review > > > Source/bmalloc/bmalloc/VMAllocate.h:204 > > +#else > > Can this be #elif? > > > Source/bmalloc/bmalloc/VMAllocate.h:205 > > +#if !BOS(LINUX) && defined(MADV_FREE) > > We do have a platform macro for FreeBSD. Can you use that? Thanks. I'll introduce BOS_FREEBSD like WTF's WTF_OS_FREEBSD. Created attachment 364583 [details]
Patch
Comment on attachment 364583 [details]
Patch
r=me
Comment on attachment 364583 [details] Patch Clearing flags on attachment: 364583 Committed r242916: <https://trac.webkit.org/changeset/242916> All reviewed patches have been landed. Closing bug. |