Bug 195665

Summary: [bmalloc] Use MADV_FREE on FreeBSD
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, don.olmstead, ggaren, webkit-bug-importer, yoshiaki.jitsukawa
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yoshiaki Jitsukawa
Reported 2019-03-13 00:07:52 PDT
[bmalloc] Use MADV_FREE for non Darwin/Linux OS if available
Attachments
Patch (1.60 KB, patch)
2019-03-13 00:17 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Patch (2.03 KB, patch)
2019-03-13 15:22 PDT, Yoshiaki Jitsukawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yoshiaki Jitsukawa
Comment 1 2019-03-13 00:17:39 PDT
Created attachment 364517 [details] Patch
Geoffrey Garen
Comment 2 2019-03-13 10:44:49 PDT
Comment on attachment 364517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364517&action=review > Source/bmalloc/bmalloc/VMAllocate.h:204 > +#else Can this be #elif? > Source/bmalloc/bmalloc/VMAllocate.h:205 > +#if !BOS(LINUX) && defined(MADV_FREE) We do have a platform macro for FreeBSD. Can you use that?
Yoshiaki Jitsukawa
Comment 3 2019-03-13 15:12:02 PDT
(In reply to Geoffrey Garen from comment #2) > Comment on attachment 364517 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364517&action=review > > > Source/bmalloc/bmalloc/VMAllocate.h:204 > > +#else > > Can this be #elif? > > > Source/bmalloc/bmalloc/VMAllocate.h:205 > > +#if !BOS(LINUX) && defined(MADV_FREE) > > We do have a platform macro for FreeBSD. Can you use that? Thanks. I'll introduce BOS_FREEBSD like WTF's WTF_OS_FREEBSD.
Yoshiaki Jitsukawa
Comment 4 2019-03-13 15:22:52 PDT
Created attachment 364583 [details] Patch
Geoffrey Garen
Comment 5 2019-03-13 15:29:21 PDT
Comment on attachment 364583 [details] Patch r=me
WebKit Commit Bot
Comment 6 2019-03-13 16:07:11 PDT
Comment on attachment 364583 [details] Patch Clearing flags on attachment: 364583 Committed r242916: <https://trac.webkit.org/changeset/242916>
WebKit Commit Bot
Comment 7 2019-03-13 16:07:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-13 16:11:05 PDT
<rdar://problem/48868091>
Note You need to log in before you can comment on or make changes to this bug.