Bug 195662

Summary: [Win][PlayStation] Remove WebCore::standardUserAgentForURL
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, rniwa, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2019-03-12 21:13:11 PDT
[Win] Remove WebCore::standardUserAgentForURL Requested by: [webkit-dev] PSA: WebCore::Quirks should define the logic to determine if a particular site specific quirk is needed or not https://lists.webkit.org/pipermail/webkit-dev/2019-March/030530.html
Attachments
Patch (2.89 KB, patch)
2019-03-12 21:46 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (3.66 KB, patch)
2019-03-12 23:17 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2019-03-12 21:46:19 PDT
Created attachment 364511 [details] Patch
Ross Kirsling
Comment 2 2019-03-12 22:45:41 PDT
LGTM assuming it suffices to remove it. Do you want to remove it from UserAgentPlayStation right away too?
Fujii Hironori
Comment 3 2019-03-12 23:17:21 PDT
Created attachment 364516 [details] Patch
Fujii Hironori
Comment 4 2019-03-13 00:48:41 PDT
Comment on attachment 364516 [details] Patch Clearing flags on attachment: 364516 Committed r242847: <https://trac.webkit.org/changeset/242847>
Fujii Hironori
Comment 5 2019-03-13 00:48:44 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2019-03-13 00:49:30 PDT
<rdar://problem/48839947>
Note You need to log in before you can comment on or make changes to this bug.