| Summary: | Fix testbmalloc build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fpizlo, ggaren, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2019-03-12 20:25:39 PDT
Created attachment 364504 [details]
Patch
Attachment 364504 [details] did not pass style-queue:
ERROR: Source/bmalloc/bmalloc/StdLibExtras.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5]
ERROR: Source/bmalloc/bmalloc/StdLibExtras.h:36: bitwise_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 2 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364504 [details]
Patch
r=me
Comment on attachment 364504 [details] Patch Clearing flags on attachment: 364504 Committed r242892: <https://trac.webkit.org/changeset/242892> All reviewed patches have been landed. Closing bug. |