| Summary: | Enable libwebrtc logging control through WebCore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2019-03-12 19:32:29 PDT
Created attachment 364501 [details]
Patch
Created attachment 364538 [details]
Patch
Comment on attachment 364538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364538&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228 > + if (!m_enableLogging) Logging can never be enabled once it has been disabled? (In reply to Eric Carlson from comment #4) > Comment on attachment 364538 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364538&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228 > > + if (!m_enableLogging) > > Logging can never be enabled once it has been disabled? Yes, the logging is process wide for now. If a private session page is in the same process as a non private session page, this might cause issues if we reenable logging and the private session page activity gets logged. Comment on attachment 364538 [details] Patch Clearing flags on attachment: 364538 Committed r242886: <https://trac.webkit.org/changeset/242886> All reviewed patches have been landed. Closing bug. |