Bug 195658

Summary: Enable libwebrtc logging control through WebCore
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2019-03-12 19:32:29 PDT
Enable libwebrtc logging control through WebCore
Attachments
Patch (10.75 KB, patch)
2019-03-12 20:24 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (10.75 KB, patch)
2019-03-13 08:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-03-12 20:24:01 PDT
Created attachment 364501 [details] Patch
youenn fablet
Comment 2 2019-03-13 08:38:16 PDT
Created attachment 364538 [details] Patch
Radar WebKit Bug Importer
Comment 3 2019-03-13 09:21:07 PDT
<rdar://problem/48849463>
Eric Carlson
Comment 4 2019-03-13 09:32:40 PDT
Comment on attachment 364538 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364538&action=review > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228 > + if (!m_enableLogging) Logging can never be enabled once it has been disabled?
youenn fablet
Comment 5 2019-03-13 09:43:01 PDT
(In reply to Eric Carlson from comment #4) > Comment on attachment 364538 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364538&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228 > > + if (!m_enableLogging) > > Logging can never be enabled once it has been disabled? Yes, the logging is process wide for now. If a private session page is in the same process as a non private session page, this might cause issues if we reenable logging and the private session page activity gets logged.
WebKit Commit Bot
Comment 6 2019-03-13 10:14:24 PDT
Comment on attachment 364538 [details] Patch Clearing flags on attachment: 364538 Committed r242886: <https://trac.webkit.org/changeset/242886>
WebKit Commit Bot
Comment 7 2019-03-13 10:14:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.