| Summary: | Move the code for determining the need for touch bar quirks to Quirks class | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, bfulgham, cdumez, ggaren, koivisto, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2019-03-12 17:18:32 PDT
(In reply to Ryosuke Niwa from comment #0) > WebPage::didApplyStyle() has the logic to determine whether hidden content > editable and plain text quirks are needed. > Move these logics to Quirks class. *WebPage::didChangeSelection Created attachment 364488 [details]
Cleanup
Created attachment 364489 [details]
Cleanup
Comment on attachment 364489 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364489&action=review > Source/WebCore/page/Quirks.cpp:159 > +#if PLATFORM(MAC) What about iOSMac? Would it maybe be needed there? > Source/WebCore/page/Quirks.cpp:172 > +#if PLATFORM(MAC) Ditto (In reply to Brent Fulgham from comment #4) > Comment on attachment 364489 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364489&action=review > > > Source/WebCore/page/Quirks.cpp:159 > > +#if PLATFORM(MAC) > > What about iOSMac? Would it maybe be needed there? Wenson says we might. But the code which uses these checks are also guarded inside PLATFORM(MAC) so we'd probably have to fix both of them. I'm gonna leave the check as is for now. Committed r242840: <https://trac.webkit.org/changeset/242840> |