Bug 195654

Summary: Move the code for determining the need for touch bar quirks to Quirks class
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: basuke, bfulgham, cdumez, ggaren, koivisto, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Cleanup bfulgham: review+

Ryosuke Niwa
Reported 2019-03-12 17:18:32 PDT
WebPage::didApplyStyle() has the logic to determine whether hidden content editable and plain text quirks are needed. Move these logics to Quirks class.
Attachments
Cleanup (19.08 KB, patch)
2019-03-12 17:59 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Cleanup (19.06 KB, patch)
2019-03-12 18:00 PDT, Ryosuke Niwa 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2019-03-12 17:20:42 PDT
(In reply to Ryosuke Niwa from comment #0) > WebPage::didApplyStyle() has the logic to determine whether hidden content > editable and plain text quirks are needed. > Move these logics to Quirks class. *WebPage::didChangeSelection
Ryosuke Niwa
Comment 2 2019-03-12 17:59:03 PDT
Created attachment 364488 [details] Cleanup
Ryosuke Niwa
Comment 3 2019-03-12 18:00:39 PDT
Created attachment 364489 [details] Cleanup
Brent Fulgham
Comment 4 2019-03-12 18:45:20 PDT
Comment on attachment 364489 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364489&action=review > Source/WebCore/page/Quirks.cpp:159 > +#if PLATFORM(MAC) What about iOSMac? Would it maybe be needed there? > Source/WebCore/page/Quirks.cpp:172 > +#if PLATFORM(MAC) Ditto
Ryosuke Niwa
Comment 5 2019-03-12 19:17:54 PDT
(In reply to Brent Fulgham from comment #4) > Comment on attachment 364489 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364489&action=review > > > Source/WebCore/page/Quirks.cpp:159 > > +#if PLATFORM(MAC) > > What about iOSMac? Would it maybe be needed there? Wenson says we might. But the code which uses these checks are also guarded inside PLATFORM(MAC) so we'd probably have to fix both of them. I'm gonna leave the check as is for now.
Ryosuke Niwa
Comment 6 2019-03-12 19:31:42 PDT
Committed r242840: <https://trac.webkit.org/changeset/242840>
Radar WebKit Bug Importer
Comment 7 2019-03-12 19:32:19 PDT
<rdar://problem/48834165>
Note You need to log in before you can comment on or make changes to this bug.