Summary: | REGRESSION(r242825): "Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||
Component: | New Bugs | Assignee: | WebKit Commit Bot <commit-queue> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | rmorisset, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 195573 | ||||||
Attachments: |
|
Description
WebKit Commit Bot
2019-03-12 15:45:33 PDT
Created attachment 364462 [details] ROLLOUT of r242825 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. Comment on attachment 364462 [details] ROLLOUT of r242825 I had forgotten that there were already tests for this code, and broke them when changing the interface of lldb_dump_class_layout.py. The fix is fairly simple, but I want to first roll-out, then take the time to fix it properly. Comment on attachment 364462 [details] ROLLOUT of r242825 Clearing flags on attachment: 364462 Committed r242832: <https://trac.webkit.org/changeset/242832> All reviewed patches have been landed. Closing bug. |