| Summary: | Add WebFrameProxy::loadData | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | bfulgham, commit-queue, jiewen_tan, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2019-03-12 15:37:09 PDT
The Internal counterpart is within: <rdar://problem/48048800>. Created attachment 364463 [details]
Patch
Comment on attachment 364463 [details] Patch It might be good to add a test for that if it is difficult to test it without additional features. Maybe we could expose a private API on the web view for testing purposes only. This API could take a frameId and some data to be loaded. TestRunner would then grab the frameId and call that new API. View in context: https://bugs.webkit.org/attachment.cgi?id=364463&action=review > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1401 > + SubstituteData substituteData(WTFMove(sharedBuffer), URL(), WTFMove(response), SubstituteData::SessionHistoryVisibility::Hidden); It is true that the above code is not doing that but I would tend to set the correct URL in both response and substituteData. (In reply to youenn fablet from comment #4) > Comment on attachment 364463 [details] > Patch > > It might be good to add a test for that if it is difficult to test it > without additional features. > > Maybe we could expose a private API on the web view for testing purposes > only. > This API could take a frameId and some data to be loaded. > TestRunner would then grab the frameId and call that new API. I am not sure whether it will be good idea to expose this into SPI, which will then be misused probably. Do we have test only SPIs? > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364463&action=review > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1401 > > + SubstituteData substituteData(WTFMove(sharedBuffer), URL(), WTFMove(response), SubstituteData::SessionHistoryVisibility::Hidden); > > It is true that the above code is not doing that but I would tend to set the > correct URL in both response and substituteData. Sure. Created attachment 364475 [details]
Patch for landing
Comment on attachment 364475 [details] Patch for landing Clearing flags on attachment: 364475 Committed r242836: <https://trac.webkit.org/changeset/242836> |