| Summary: | Device Orientation access permission should be denied unless explicitly granted by the client | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, commit-queue, ews-watchlist, ggaren, rniwa, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2019-03-12 09:41:07 PDT
Created attachment 364394 [details]
Patch
Attachment 364394 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:94: More than one command on the same line [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:97: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364394 [details] Patch Clearing flags on attachment: 364394 Committed r242823: <https://trac.webkit.org/changeset/242823> All reviewed patches have been landed. Closing bug. |