| Summary: | Move the remaining code to decide whether site specific quirks are needed to Quirks class | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
| Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, ggaren, jer.noble, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryosuke Niwa
2019-03-12 00:26:19 PDT
Created attachment 364364 [details]
Cleanup
Comment on attachment 364364 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=364364&action=review > Source/WebCore/page/Quirks.cpp:80 > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const The second 'Quirk' is redundant. (In reply to Antti Koivisto from comment #2) > Comment on attachment 364364 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364364&action=review > > > Source/WebCore/page/Quirks.cpp:80 > > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const > > The second 'Quirk' is redundant. Fixed. Created attachment 364376 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 364376 [details]: legacy-animation-engine/cssom/cssvalue-comparison.html bug 195617 (authors: dino@apple.com and graouts@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 364376 [details] Patch for landing Clearing flags on attachment: 364376 Committed r242792: <https://trac.webkit.org/changeset/242792> All reviewed patches have been landed. Closing bug. |