Web Inspector: Timelines - Improve handling of past recordings (readonly)

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Timelines - Improve handling of past recordings (readonly)

Steps to Reproduce:
1. Inspect a page
2. Show Timelines tab
3. Reload + stop recording
  => Timeline Recording 1
4. Reload + stop recording
  => Timeline Recording 2
5. Switch to Timeline Recording 1
  => Usability issues

Issue:
• Ability to start a recording continues this readonly recording... should probably not
• Ability to clear recording with Cmd+K keyboard shortcut (button was disabled)

[Joseph Pecoraro]

Created attachment 364330 [details]
[PATCH] Proposed Fix

[Devin Rousso]

Comment on attachment 364330 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364330&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:487
> +        if (WI.timelineManager.activeRecording.readonly)
> +            shouldCreateNewRecording = true;

Should we also change the tooltip of the record button to remove the non-`shouldCreateNewRecording` text?  e.g. `"Start recording (%s)\nCreate new recording (%s)"` becomes `"Create new recording (%s)"` when the active recording is readonly (and vice versa).

[Joseph Pecoraro]

(In reply to Devin Rousso from comment #2)
> Comment on attachment 364330 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364330&action=review
> 
> rs=me
> 
> > Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js:487
> > +        if (WI.timelineManager.activeRecording.readonly)
> > +            shouldCreateNewRecording = true;
> 
> Should we also change the tooltip of the record button to remove the
> non-`shouldCreateNewRecording` text?  e.g. `"Start recording (%s)\nCreate
> new recording (%s)"` becomes `"Create new recording (%s)"` when the active
> recording is readonly (and vice versa).

Naw, I don't think this is common enough to warrant it. I think the current tooltip is still reasonably accurate even in the readonly case, it will start a recording!

[WebKit Commit Bot]

Comment on attachment 364330 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 364330

Committed r242785: <https://trac.webkit.org/changeset/242785>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48799997>