| Summary: | [JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yusuke Suzuki
2019-03-11 18:01:35 PDT
Created attachment 364328 [details]
Patch
Comment on attachment 364328 [details] Patch Attachment 364328 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11465019 Number of test failures exceeded the failure limit. Created attachment 364335 [details]
Archive of layout-test-results from ews102 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
Comment on attachment 364328 [details]
Patch
Fixing crashes.
Created attachment 364337 [details]
Patch
Comment on attachment 364337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review r=me. > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200 > + if (ArrayPrototypeInternal::verbose) > + dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n"); Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...) Comment on attachment 364337 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200 >> + dataLog("Initializing Array species watchpoints for Array.prototype: ", pointerDump(arrayPrototype), " with structure: ", pointerDump(arrayPrototype->structure(vm)), "\nand Array: ", pointerDump(globalObject->arrayConstructor()), " with structure: ", pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n"); > > Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...) Sounds better! Fixed. Committed r242902: <https://trac.webkit.org/changeset/242902> |