Bug 195589

Summary:

Web Inspector: DOM: lazily create the agent

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

195592

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2019-03-11 17:51:53 PDT

Attachments
Patch (36.48 KB, patch) 2019-03-17 18:21 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (36.17 KB, patch) 2019-03-20 10:59 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (36.20 KB, patch) 2019-03-20 12:05 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (40.82 KB, patch) 2019-03-20 16:20 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-11 17:54:16 PDT

<rdar://problem/48791742>

Devin Rousso

Comment 2 2019-03-17 18:21:44 PDT

Created attachment 364992 [details] Patch

WebKit Commit Bot

Comment 3 2019-03-20 10:15:38 PDT Comment hidden (obsolete)

Comment on attachment 364992 [details] Patch Rejecting attachment 364992 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 364992, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=364992&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=195589&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 364992 from bug 195589. Fetching: https://bugs.webkit.org/attachment.cgi?id=364992 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 12 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/inspector/InspectorController.cpp Hunk #2 FAILED at 134. Hunk #3 succeeded at 174 (offset -14 lines). Hunk #4 succeeded at 387 (offset -6 lines). Hunk #5 succeeded at 408 (offset -6 lines). 1 out of 5 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorController.cpp.rej patching file Source/WebCore/inspector/InspectorController.h patching file Source/WebCore/inspector/InspectorStyleSheet.cpp patching file Source/WebCore/inspector/agents/InspectorCSSAgent.cpp patching file Source/WebCore/inspector/agents/InspectorCSSAgent.h patching file Source/WebCore/inspector/agents/InspectorDOMAgent.cpp patching file Source/WebCore/inspector/agents/InspectorDOMAgent.h patching file Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp Hunk #1 FAILED at 62. Hunk #2 succeeded at 232 (offset 4 lines). Hunk #3 succeeded at 256 (offset 4 lines). Hunk #4 succeeded at 328 (offset 4 lines). Hunk #5 succeeded at 354 (offset 4 lines). Hunk #6 succeeded at 402 with fuzz 2 (offset 13 lines). 1 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.cpp.rej patching file Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.h Hunk #1 succeeded at 47 (offset 4 lines). Hunk #2 succeeded at 56 (offset 4 lines). Hunk #3 FAILED at 101. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/inspector/agents/InspectorDOMDebuggerAgent.h.rej patching file Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp Hunk #1 FAILED at 34. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp.rej patching file Source/WebCore/inspector/agents/page/PageConsoleAgent.h Hunk #1 FAILED at 36. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/inspector/agents/page/PageConsoleAgent.h.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/11581315

Devin Rousso

Comment 4 2019-03-20 10:59:18 PDT

Created attachment 365360 [details] Patch

Devin Rousso

Comment 5 2019-03-20 12:05:58 PDT

Created attachment 365380 [details] Patch

Devin Rousso

Comment 6 2019-03-20 16:20:15 PDT

Created attachment 365428 [details] Patch

WebKit Commit Bot

Comment 7 2019-03-20 20:10:33 PDT

Comment on attachment 365428 [details] Patch Clearing flags on attachment: 365428 Committed r243273: <https://trac.webkit.org/changeset/243273>

WebKit Commit Bot

Comment 8 2019-03-20 20:10:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.