Bug 195588 – Web Inspector: DOMStorage: lazily create the agent

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/48791878>

[Devin Rousso]

Created attachment 364971 [details]
Patch

[Devin Rousso]

Created attachment 364976 [details]
Patch

[Devin Rousso]

Comment on attachment 364976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364976&action=review

> Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:184
> +        errorString = "Missing page agent"_s;

This should probably be `"Missing Page agent"`.

[Joseph Pecoraro]

Comment on attachment 364976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364976&action=review

r=me

> Source/WebCore/inspector/CommandLineAPIHost.cpp:169
> -    if (m_domStorageAgent)
> -        return m_domStorageAgent->storageId(storage);
> -    return { };
> +    return InspectorDOMStorageAgent::storageId(storage);

Nice!

>> Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp:184
>> +        errorString = "Missing page agent"_s;
> 
> This should probably be `"Missing Page agent"`.

Agreed.

[Devin Rousso]

Created attachment 365182 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365182 [details]
Patch

Rejecting attachment 365182 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 365182, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365182&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195588&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 365182 from bug 195588.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365182
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 7 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/inspector/CommandLineAPIHost.cpp
patching file Source/WebCore/inspector/CommandLineAPIHost.h
patching file Source/WebCore/inspector/InspectorController.cpp
Hunk #1 FAILED at 127.
Hunk #2 succeeded at 138 (offset -4 lines).
Hunk #3 succeeded at 188 (offset -4 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorController.cpp.rej
patching file Source/WebCore/inspector/WorkerInspectorController.cpp
Hunk #1 succeeded at 77 with fuzz 1 (offset -3 lines).
patching file Source/WebCore/inspector/agents/InspectorDOMStorageAgent.cpp
patching file Source/WebCore/inspector/agents/InspectorDOMStorageAgent.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11567901

[Devin Rousso]

Created attachment 365193 [details]
Patch

Include drive-by fix from r243150 <https://trac.webkit.org/changeset/243150>: move creation of Heap agent outside `ENABLE(RESOURCE_USAGE)` block

[WebKit Commit Bot]

Comment on attachment 365193 [details]
Patch

Clearing flags on attachment: 365193

Committed r243158: <https://trac.webkit.org/changeset/243158>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.