| Summary: | API test WebKit.RequestTextInputContext fails on iOS | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dino, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2019-03-11 17:46:06 PDT
Created attachment 364320 [details]
Patch
Comment on attachment 364320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364320&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:4834 > + // FIXME: It should be easier to talk about WKWebView coordinates in a consistent and cross-platform way. > + // Currently, neither "root view" nor "window" mean "WKWebView coordinates" on both platforms. You should probably reference webkit.org/b/193649 Created attachment 364325 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 364325 [details]: legacy-animation-engine/compositing/updates/animation-non-composited.html bug 195596 (author: graouts@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 364325 [details] Patch Clearing flags on attachment: 364325 Committed r242762: <https://trac.webkit.org/changeset/242762> All reviewed patches have been landed. Closing bug. |