Bug 195579

Summary: A lot more classes have padding that can be reduced by reordering their fields
Product: WebKit Reporter: Robin Morisset <rmorisset>
Component: JavaScriptCoreAssignee: Robin Morisset <rmorisset>
Status: RESOLVED FIXED    
Severity: Trivial CC: benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Robin Morisset
Reported 2019-03-11 16:44:10 PDT
Just a bunch more in the same style as the ones I committed on Friday.
Attachments
Patch (30.37 KB, patch)
2019-03-11 16:49 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Patch (31.00 KB, patch)
2019-03-11 18:04 PDT, Robin Morisset 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.48 MB, application/zip)
2019-03-11 23:36 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Morisset
Comment 1 2019-03-11 16:49:24 PDT
Created attachment 364309 [details] Patch
EWS Watchlist
Comment 2 2019-03-11 16:53:04 PDT
Attachment 364309 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:115: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:84: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 7 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2019-03-11 17:05:26 PDT
Comment on attachment 364309 [details] Patch r=me if EWS shows no regression.
Robin Morisset
Comment 4 2019-03-11 18:04:49 PDT
Created attachment 364326 [details] Patch
EWS Watchlist
Comment 5 2019-03-11 18:07:18 PDT
Attachment 364326 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:115: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:84: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4] Total errors found: 7 in 35 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 6 2019-03-11 23:36:24 PDT
Comment on attachment 364326 [details] Patch Attachment 364326 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11467979 New failing tests: fast/events/change-overflow-on-overflow-change.html
EWS Watchlist
Comment 7 2019-03-11 23:36:27 PDT
Created attachment 364357 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Robin Morisset
Comment 8 2019-03-12 11:39:49 PDT
Comment on attachment 364326 [details] Patch This failure of EWS looks like flakiness of the tests considering that both jsc and Mac-debug are green.
WebKit Commit Bot
Comment 9 2019-03-12 12:07:10 PDT
Comment on attachment 364326 [details] Patch Clearing flags on attachment: 364326 Committed r242812: <https://trac.webkit.org/changeset/242812>
WebKit Commit Bot
Comment 10 2019-03-12 12:07:12 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-03-12 12:08:36 PDT
<rdar://problem/48817827>
Note You need to log in before you can comment on or make changes to this bug.