Summary: | A lot more classes have padding that can be reduced by reordering their fields | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Trivial | CC: | benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Robin Morisset
2019-03-11 16:44:10 PDT
Created attachment 364309 [details]
Patch
Attachment 364309 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:115: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:84: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 7 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364309 [details]
Patch
r=me if EWS shows no regression.
Created attachment 364326 [details]
Patch
Attachment 364326 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:139: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:140: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGPlan.cpp:144: Wrong number of spaces before statement. (expected: 8) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSlowPathGenerator.h:115: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGArrayifySlowPathGenerator.h:47: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:46: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/dfg/DFGCallArrayAllocatorSlowPathGenerator.h:84: Wrong number of spaces before statement. (expected: 12) [whitespace/indent] [4]
Total errors found: 7 in 35 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364326 [details] Patch Attachment 364326 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/11467979 New failing tests: fast/events/change-overflow-on-overflow-change.html Created attachment 364357 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 364326 [details]
Patch
This failure of EWS looks like flakiness of the tests considering that both jsc and Mac-debug are green.
Comment on attachment 364326 [details] Patch Clearing flags on attachment: 364326 Committed r242812: <https://trac.webkit.org/changeset/242812> All reviewed patches have been landed. Closing bug. |