Summary: | Rename originsMatch in originSerializationsMatch | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, jiewen_tan, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=195362 | ||||||||
Attachments: |
|
Description
youenn fablet
2019-03-11 14:24:09 PDT
Created attachment 364286 [details]
Patch
Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review > Source/WebCore/ChangeLog:3 > + Rename originsMatch in originSerializationsMatch Will serializedOriginsMatch be a better name? Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review >> Source/WebCore/ChangeLog:3 >> + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Anymore, they are more or less the same. LGTM. r=me. (In reply to Jiewen Tan from comment #3) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > >> Source/WebCore/ChangeLog:3 > >> + Rename originsMatch in originSerializationsMatch > > > > Will serializedOriginsMatch be a better name? > > Anymore, they are more or less the same. LGTM. r=me. I mean anyway... Created attachment 364399 [details]
Patch for landing
Comment on attachment 364399 [details] Patch for landing Clearing flags on attachment: 364399 Committed r242804: <https://trac.webkit.org/changeset/242804> All reviewed patches have been landed. Closing bug. (In reply to Jiewen Tan from comment #2) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Sounds better indeed, changed in the landing patch. |