Bug 195572

Summary: Rename originsMatch in originSerializationsMatch
Product: WebKit Reporter: youenn fablet <youennf>
Component: Page LoadingAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195362
Attachments:
Description Flags
Patch
none
Patch for landing none

youenn fablet
Reported 2019-03-11 14:24:09 PDT
Rename originsMatch in originSerializationsMatch. That will make it clearer the intent of this method.
Attachments
Patch (7.95 KB, patch)
2019-03-11 14:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.93 KB, patch)
2019-03-12 10:16 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-03-11 14:26:42 PDT
Created attachment 364286 [details] Patch
Jiewen Tan
Comment 2 2019-03-11 18:45:55 PDT
Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review > Source/WebCore/ChangeLog:3 > + Rename originsMatch in originSerializationsMatch Will serializedOriginsMatch be a better name?
Jiewen Tan
Comment 3 2019-03-11 18:52:28 PDT
Comment on attachment 364286 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364286&action=review >> Source/WebCore/ChangeLog:3 >> + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Anymore, they are more or less the same. LGTM. r=me.
Jiewen Tan
Comment 4 2019-03-11 18:52:45 PDT
(In reply to Jiewen Tan from comment #3) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > >> Source/WebCore/ChangeLog:3 > >> + Rename originsMatch in originSerializationsMatch > > > > Will serializedOriginsMatch be a better name? > > Anymore, they are more or less the same. LGTM. r=me. I mean anyway...
youenn fablet
Comment 5 2019-03-12 10:16:11 PDT
Created attachment 364399 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-03-12 11:08:23 PDT
Comment on attachment 364399 [details] Patch for landing Clearing flags on attachment: 364399 Committed r242804: <https://trac.webkit.org/changeset/242804>
WebKit Commit Bot
Comment 7 2019-03-12 11:08:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-03-12 11:33:03 PDT
<rdar://problem/48816174>
youenn fablet
Comment 9 2019-03-13 09:49:03 PDT
(In reply to Jiewen Tan from comment #2) > Comment on attachment 364286 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364286&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename originsMatch in originSerializationsMatch > > Will serializedOriginsMatch be a better name? Sounds better indeed, changed in the landing patch.
Note You need to log in before you can comment on or make changes to this bug.