| Summary: | Update device orientation & motion permission native SPI as per latest proposal | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, beidson, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2019-03-11 12:54:18 PDT
Created attachment 364281 [details]
Patch
Attachment 364281 [details] did not pass style-queue:
ERROR: Source/WebCore/page/ChromeClient.h:486: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
Total errors found: 1 in 16 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 364281 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364281&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:181 > +- (void)_webView:(WKWebView *)webView shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:(WKFrameInfo *)securityOrigin decisionHandler:(void (^)(BOOL))decisionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA)); s/securityOrigin/requestingFrame/ Committed r242753: <https://trac.webkit.org/changeset/242753> |