| Summary: | Support <object>.contentWindow | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anne van Kesteren <annevk> | ||||||
| Component: | DOM | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | achristensen, cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, kondapallykalyan, rniwa, sam, sroberts, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=195748 | ||||||||
| Attachments: |
|
||||||||
|
Description
Anne van Kesteren
2019-03-11 09:35:49 PDT
Created attachment 366208 [details]
Patch
Created attachment 366209 [details]
Patch
Comment on attachment 366209 [details] Patch Clearing flags on attachment: 366209 Committed r243638: <https://trac.webkit.org/changeset/243638> All reviewed patches have been landed. Closing bug. After revision https://trac.webkit.org/changeset/243638/webkit the following layout test is now consistently failing: imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/navigated-named-objects.window.html Test is failing 100% on dashboard and through local testing. Ran tests again r243637 and they are passing. Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fthe-window-object%2Fnamed-access-on-the-window-object%2Fnavigated-named-objects.window.html Diff: --- /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/navigated-named-objects.window-expected.txt +++ /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access-on-the-window-object/navigated-named-objects.window-actual.txt @@ -2,7 +2,7 @@ PASS Window's associated Document object is used for finding named objects (<div> via srcdoc <iframe>) PASS Window's associated Document object is used for finding named objects (<object> via srcdoc <iframe>) PASS Window's associated Document object is used for finding named objects (<iframe> via srcdoc <iframe>) -FAIL Window's associated Document object is used for finding named objects (<object> with browsing ccontext via srcdoc <iframe)> assert_equals: expected (object) null but got (undefined) undefined +PASS Window's associated Document object is used for finding named objects (<object> with browsing ccontext via srcdoc <iframe)> FAIL Window's associated Document object is used for finding named objects (<div> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is undefined) FAIL Window's associated Document object is used for finding named objects (<object> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is undefined) FAIL Window's associated Document object is used for finding named objects (<iframe> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is undefined) (In reply to Shawn Roberts from comment #6) > After revision https://trac.webkit.org/changeset/243638/webkit the following > layout test is now consistently failing: > > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > on-the-window-object/navigated-named-objects.window.html > > Test is failing 100% on dashboard and through local testing. Ran tests again > r243637 and they are passing. > > Dashboard: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > tests%2Fhtml%2Fbrowsers%2Fthe-window-object%2Fnamed-access-on-the-window- > object%2Fnavigated-named-objects.window.html > > Diff: > > --- > /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > on-the-window-object/navigated-named-objects.window-expected.txt > +++ > /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/ > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > on-the-window-object/navigated-named-objects.window-actual.txt > @@ -2,7 +2,7 @@ > PASS Window's associated Document object is used for finding named objects > (<div> via srcdoc <iframe>) > PASS Window's associated Document object is used for finding named objects > (<object> via srcdoc <iframe>) > PASS Window's associated Document object is used for finding named objects > (<iframe> via srcdoc <iframe>) > -FAIL Window's associated Document object is used for finding named objects > (<object> with browsing ccontext via srcdoc <iframe)> assert_equals: > expected (object) null but got (undefined) undefined > +PASS Window's associated Document object is used for finding named objects > (<object> with browsing ccontext via srcdoc <iframe)> > FAIL Window's associated Document object is used for finding named objects > (<div> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > undefined) > FAIL Window's associated Document object is used for finding named objects > (<object> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > undefined) > FAIL Window's associated Document object is used for finding named objects > (<iframe> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > undefined) Clearly a progression, Ill rebaseline. (In reply to Chris Dumez from comment #7) > (In reply to Shawn Roberts from comment #6) > > After revision https://trac.webkit.org/changeset/243638/webkit the following > > layout test is now consistently failing: > > > > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > > on-the-window-object/navigated-named-objects.window.html > > > > Test is failing 100% on dashboard and through local testing. Ran tests again > > r243637 and they are passing. > > > > Dashboard: > > > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > > html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform- > > tests%2Fhtml%2Fbrowsers%2Fthe-window-object%2Fnamed-access-on-the-window- > > object%2Fnavigated-named-objects.window.html > > > > Diff: > > > > --- > > /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > > on-the-window-object/navigated-named-objects.window-expected.txt > > +++ > > /Volumes/Data/slave/mojave-debug-tests-wk2/build/layout-test-results/ > > imported/w3c/web-platform-tests/html/browsers/the-window-object/named-access- > > on-the-window-object/navigated-named-objects.window-actual.txt > > @@ -2,7 +2,7 @@ > > PASS Window's associated Document object is used for finding named objects > > (<div> via srcdoc <iframe>) > > PASS Window's associated Document object is used for finding named objects > > (<object> via srcdoc <iframe>) > > PASS Window's associated Document object is used for finding named objects > > (<iframe> via srcdoc <iframe>) > > -FAIL Window's associated Document object is used for finding named objects > > (<object> with browsing ccontext via srcdoc <iframe)> assert_equals: > > expected (object) null but got (undefined) undefined > > +PASS Window's associated Document object is used for finding named objects > > (<object> with browsing ccontext via srcdoc <iframe)> > > FAIL Window's associated Document object is used for finding named objects > > (<div> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > > undefined) > > FAIL Window's associated Document object is used for finding named objects > > (<object> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > > undefined) > > FAIL Window's associated Document object is used for finding named objects > > (<iframe> via same-origin <iframe>) f is not a function. (In 'f()', 'f' is > > undefined) > > Clearly a progression, Ill rebaseline. https://trac.webkit.org/r243646 |