| Summary: | [ews-build] unit-tests fail when passwords.json is missing | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=180390 | ||||||
| Attachments: |
|
||||||
Created attachment 364253 [details]
Proposed patch
Comment on attachment 364253 [details] Proposed patch Clearing flags on attachment: 364253 Committed r242707: <https://trac.webkit.org/changeset/242707> All reviewed patches have been landed. Closing bug. |
unit-tests in loadConfig_unittest.py fail when passwords.json is missing. This file is not checked-in to the repository. So the unit-tests should be able to run without this file. Exception: [~/OpenSource/Tools/BuildSlaveSupport/ews-build]$python runUnittests.py ......................................................E.................... ====================================================================== ERROR: test_configuration (loadConfig_unittest.ConfigDotJSONTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py", line 36, in test_configuration loadConfig.loadBuilderConfig({}, master_prefix_path=cwd) File "/Users/jain/code/OpenSource/Tools/BuildSlaveSupport/ews-build/loadConfig.py", line 42, in loadBuilderConfig passwords = json.load(open(os.path.join(master_prefix_path, 'passwords.json'))) IOError: [Errno 2] No such file or directory: 'passwords.json'