Bug 195555 – [EME] generateRequest was not using the sanitized init data

• Component: New Bugs
• Status: RESOLVED FIXED

[Xabier Rodríguez Calvar]

[EME] generateRequest was not using the sanitized init data

[Xabier Rodríguez Calvar]

Created attachment 364251 [details]
Patch

[Jon Lee]

Comment on attachment 364251 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364251&action=review

> Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp:203
> +        m_instanceSession->requestLicense(m_sessionType, initDataType, sanitizedInitData.releaseNonNull(), [this, weakThis = makeWeakPtr(*this), promise = WTFMove(promise)] (Ref<SharedBuffer>&& message, const String& sessionId, bool needsIndividualization, CDMInstanceSession::SuccessValue succeeded) mutable {

How can we test this?

[Xabier Rodríguez Calvar]

(In reply to Jon Lee from comment #2)
> How can we test this?

I think there should be a W3C test for this if there is none, idealy for ClearKey.

Anyway for our current code for ClearKey it can't be properly tested as we'd never reach that codepath. We don't have a sanitation code path either for cenc or WebM that modifies the init data without raising an error and returning an empty init data.

I'm landing the patch, if we think we require further testing, we can open another bug.

[WebKit Commit Bot]

Comment on attachment 364251 [details]
Patch

Clearing flags on attachment: 364251

Committed r242787: <https://trac.webkit.org/changeset/242787>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48801163>