Bug 195554

Summary:

Add web audio release logging

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Web Audio

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, jer.noble, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Eric Carlson 2019-03-11 07:36:15 PDT

Add some web audio release logging

Comment 1 Radar WebKit Bug Importer 2019-03-11 08:04:27 PDT

<rdar://problem/48767211>

Comment 2 Eric Carlson 2019-03-11 10:13:36 PDT

Created attachment 364265 [details]
Patch

Comment 3 EWS Watchlist 2019-03-11 10:16:12 PDT

Attachment 364265 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webaudio/AudioNode.cpp:69:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 WebKit Commit Bot 2019-03-11 13:19:55 PDT

Comment on attachment 364265 [details]
Patch

Clearing flags on attachment: 364265

Committed r242734: <https://trac.webkit.org/changeset/242734>

Comment 5 WebKit Commit Bot 2019-03-11 13:19:57 PDT

All reviewed patches have been landed.  Closing bug.