Bug 195554

Summary: Add web audio release logging
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: Web AudioAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2019-03-11 07:36:15 PDT
Add some web audio release logging
Attachments
Patch (52.98 KB, patch)
2019-03-11 10:13 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-03-11 08:04:27 PDT
<rdar://problem/48767211>
Eric Carlson
Comment 2 2019-03-11 10:13:36 PDT
Created attachment 364265 [details] Patch
EWS Watchlist
Comment 3 2019-03-11 10:16:12 PDT
Attachment 364265 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/webaudio/AudioNode.cpp:69: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 4 2019-03-11 13:19:55 PDT
Comment on attachment 364265 [details] Patch Clearing flags on attachment: 364265 Committed r242734: <https://trac.webkit.org/changeset/242734>
WebKit Commit Bot
Comment 5 2019-03-11 13:19:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.