Bug 195542

Summary: Add utility function to allow easy reverse range-based iteration of a container
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sam Weinig
Reported 2019-03-10 20:59:13 PDT
Add utility function to allow easy reverse range-based iteration of a container
Attachments
Patch (10.40 KB, patch)
2019-03-10 21:05 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2019-03-13 18:45 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (10.29 KB, patch)
2019-03-13 19:07 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2019-03-10 21:05:38 PDT
Created attachment 364227 [details] Patch
WebKit Commit Bot
Comment 2 2019-03-11 08:25:14 PDT
Comment on attachment 364227 [details] Patch Clearing flags on attachment: 364227 Committed r242702: <https://trac.webkit.org/changeset/242702>
WebKit Commit Bot
Comment 3 2019-03-11 08:25:16 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2019-03-11 08:26:23 PDT
<rdar://problem/48767598>
Truitt Savell
Comment 5 2019-03-11 08:47:30 PDT
Looks like https://trac.webkit.org/changeset/242702/webkit just broke High Sierra: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20%28Build%29/builds/12817 /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/IteratorRange.cpp:46:42: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WTF/IteratorRange.cpp:65:42: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] Can this be resolved quickly? Otherwise this will be rolled out.
Truitt Savell
Comment 6 2019-03-11 09:25:46 PDT
Reverted r242702 for reason: Broke High Sierra builders. Committed r242706: <https://trac.webkit.org/changeset/242706>
Sam Weinig
Comment 7 2019-03-13 18:45:31 PDT
Created attachment 364605 [details] Patch
Sam Weinig
Comment 8 2019-03-13 19:07:41 PDT
Created attachment 364607 [details] Patch
WebKit Commit Bot
Comment 9 2019-03-13 19:46:22 PDT
Comment on attachment 364607 [details] Patch Clearing flags on attachment: 364607 Committed r242932: <https://trac.webkit.org/changeset/242932>
WebKit Commit Bot
Comment 10 2019-03-13 19:46:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.