[ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[Radar WebKit Bug Importer]

<rdar://problem/48740098>

[zalan]

Created attachment 364130 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 364130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364130&action=review

> Source/WebCore/ChangeLog:9
> +        Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups.

Maybe say something about the other changes in this patch.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:352
> +    if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <= -999)
> +        return true;

What about negative X?
Don't you also need to check the element width? Something at -999 could be on-screen, especially if it has 100% width on iPad.
You should also add a test for this.

[zalan]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 364130 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364130&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Unfortunately seriouseats has a 300ms hover intent delay to deal with accidental menupane pop-ups.
> 
> Maybe say something about the other changes in this patch.
I did, it's next to "StyleChangeScope::isConsideredHidden const" but yeah, I should put some more words in there.

> 
> > Source/WebCore/page/ios/ContentChangeObserver.cpp:352
> > +    if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <= -999)
> > +        return true;
> 
> What about negative X?
> Don't you also need to check the element width? Something at -999 could be
> on-screen, especially if it has 100% width on iPad.
That case is covered already. This is about when we don't know the exact width (percent or calculated) and the _out-of-flow_ content seems suspiciously positioned to the far left.

> You should also add a test for this.

[zalan]

Created attachment 364157 [details]
Patch

[zalan]

Created attachment 364160 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364160 [details]
Patch

Clearing flags on attachment: 364160

Committed r242679: <https://trac.webkit.org/changeset/242679>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.